more accurate mock lock data#74
Merged
neersighted merged 1 commit intopython-poetry:mainfrom Jun 9, 2022
dimbleby:more-accurate-mock-locker
Merged
more accurate mock lock data#74neersighted merged 1 commit intopython-poetry:mainfrom dimbleby:more-accurate-mock-locker
neersighted merged 1 commit intopython-poetry:mainfrom
dimbleby:more-accurate-mock-locker
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
neersighted
approved these changes
Jun 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update to the mock data in one of the tests matches what poetry actually does, and I think would be sufficient to allow python-poetry/poetry#5819 to pass its pipelines.
ie the proposed sequence is: merge this, merge python-poetry/poetry#5819, merge #73.
(modulo review agreeing that any of these want merging at all, obviously)