Skip to content

sdist: find packages incorrectly including non-package directories during setup.py generation #2283

@abn

Description

@abn

The issue occurs when attempting poetry install on https://github.com/python-poetry/core/tree/1172536cac35ca4e2519b9bd516ae8f1cf23994a. This only occurs when using poetry at 1.1.0a1 or current devel branch. 1.0.5 works without issue.

The broken path is triggered due to the inclusion of tests as a package source.

packages = [
    {include = "poetry"},
    {include = "tests", format = "sdist"},
]

Log and generated setup.py file is available at https://gist.github.com/abn/669c95565b957f6267cda71c2078278e.

Issue seems to be related to how setup.py is populated with packages = It treats non-package directories as packages, hence causing pip editable install to fail.

Note that this might be a low priority issue if we decide to drop setup.py generation in the future.

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind/bugSomething isn't working as expected

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions