Add support for `scripts`

[ojii]

It would be nice if poetry supported the scripts feature of setuptools (note: this is not the same as entry points).

I tried using a custom build script but it seems to be ignored by poetry when building wheels.

[cauebs]

So, this already works:

[tool.poetry.scripts]
funniest-joke = "funniest.command_line:main"

Maybe we could support this as well:

[tool.poetry.scripts]
funniest-joke = { path = "bin/funniest-joke" }

...analogous to how we can specify dependencies.
@sdispater what do you think?

[ojii]

Thanks for the info, I tried a scripts key under [tool.poetry]. I either missed that in the docs or it isn't there (if that's the case, I'll try to open a PR tomorrow).

[cauebs]

It's documented here: https://poetry.eustace.io/docs/pyproject/#scripts
But I often miss these things as well :P

[ojii]

Ah I misread your initial comments. What's called "scripts" in poetry is called "entry points/console scripts" in setuptools. What I'm referring to is the "scripts" keyword to setup(...) which lets you specify things files as scripts (as opposed to python modules + functions). So it's the second example in your first comment I'm interested in.

If at all possible, if those scripts could be somehow selected per-platform, that would be amazing (maybe only for platform-specific wheels?)

[ojii]

For those interested, I'm working on this at https://github.com/ojii/poetry/tree/non-python-scripts

[cauebs]

@ojii I was just testing you fork and it appears to be working, but I think the syntax I proposed is misleading unless you rename the script, which is something setuptools doesn't do.

Say I have this in my pyproject.toml

[tool.poetry.scripts]
cli = { path = "foo/bar" }

I might expect to be able to run cli, but only bar will work.
You could either rename the script to whatever is specified, to maintain the same syntax, or we can change the syntax, but I can't think of anything.

[ojii]

You could either rename the script to whatever is specified, to maintain the same syntax, or we can change the syntax, but I can't think of anything.

I think it's reasonable to just reject those scripts if the filename does not match the key. (In setuptools, it's a list, not a mapping).

[markovendelin]

I think it's reasonable to just reject those scripts if the filename does not match the key. (In setuptools, it's a list, not a mapping).

Not sure that such rejection would be reasonable. As a user, I would expect either a list of scripts (for plain copy) or mapping with renaming. Having to enter mapping with the same data entered twice (key and part of the value) does seem to be just a source for errors on user's side.

[ojii]

@cauebs @markovendelin I've updated my branch to re-name the scripts according to the users configuration. Should I open a PR or are there other blocking issues with this?

[cauebs]

Pretty cool! Worthy of a PR, in my opinion.

[rsantosCL]

Are there plans to merge #304 any time soon? I've been recommending poetry in the company I work for, but sadly, this feature is a must have :(

Edit: Maybe there is a workaround that @cauebs or @sdispater can recommend for this in the meanwhile.

[Kamforka]

Is the script section able to execute commands that can help you integrate developer tasks into poetry?

I imagine it like this:

[tool.poetry.scripts]
test = "pytest tests/ --verbose"

It would be a nice feature to have, what do you think?