Publish prints "publishing to PyPI", even in case of private repository

[ariebovenberg]

• I am on the latest Poetry version.
• I have searched the issues of this repo and believe that this is not a duplicate.
• If an exception occurs when executing a command, I executed it again in debug mode (-vvv option).

Other details:

• Poetry version: 1.1.0b2

Issue

When publishing to a private repository, poetry still outputs publishing <file> to PyPI.

I traced it to this code, which puzzles me a bit. It seems it will always output PyPI

poetry/poetry/publishing/publisher.py

Lines 84 to 91 in 02d4d0c

	self._io.write_line(
	"Publishing <c1>{}</c1> (<c2>{}</c2>) "
	"to <info>{}</info>".format(
	self._package.pretty_name,
	self._package.pretty_version,
	{"pypi": "PyPI"}.get(repository_name, "PyPI"),
	)
	)

Is there something I'm missing here? Should it just be {"pypi": "PyPI"}.get(repository_name, repository_name) instead? If so, I'd be happy to make a PR.

[finswimmer]

Hello @ariebovenberg,

yes this line does not make sense to me either. This will always return PyPI. Your suggestion looks good to me. Even if I'm thinking about whether {"pypi": "PyPI"}.get(repository_name) or repository_name might be more clear 🤔 No idea :)

[ariebovenberg]

The larger issue seems to be that a repository has a "slug" name (e.g.pypi) and a "display" name (e.g. PyPI). I could imagine this would be useful to support for private repositories as well.

I'll submit a PR for the bug soon. I'm leaning towards the explicit "PyPI" if repsitory_name == "pypi" else repository_name.

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.