`poetry update` with git-based dependencies updates `poetry.lock` but not the virtual environment

[IaroslavR]

• I am on the latest Poetry version.
• I have searched the issues of this repo and believe that this is not a duplicate.
• If an exception occurs when executing a command, I executed it again in debug mode (-vvv option).

• OS version and name: Ubuntu 18.04.5 LTS
• Poetry version: 1.1.6
• Link of a Gist with the contents of your pyproject.toml file: https://gist.github.com/IaroslavR/cfe6372de78b45c8be80b819f0a6112e

Issue

Almost identical to #2921 with only one difference, I have a git dependency that is defined with a revision instead of branch. When I change rev="v0.1.2" to rev="v0.1.3" poetry.lock successfully updated with the correct commit resolved_reference but the library in the virtual environment remains checked-out at the commit that was latest when poetry install was last run.

[wakemaster39]

I have a proposed fix for this in #3867, poetry is not detecting it is a git installation properly.

[iainvm]

The fix put in for #3867 doesn't seem to be working for many, and isn't working for me either, but the issue has been closed. So Hopefully this open issue will get some traction?

[aptlin]

Any updates?

[Ivorforce]

I can confirm the fix in #3867 works for me (git rev= syntax).

However, the latest poetry release does not include the fix yet (poetry 1.1.8 from August 19th).

If you are willing to try a poetry pre-release:

poetry self update --preview

Note that poetry.lock files created by the 1.2 preview may be incompatible with those of the stable versions.

If you want the fix as a hotfix to poetry 1.1.x:

# Extract the venv path from this file (second line):
cat `which poetry`
# Add the hotfix to this file. For me, it needed to go into line 68.
nano <VENV>/lib/python3.8/site-packages/poetry/repositories/installed_repository.py

The hotfix, for quick reference (credit to @wakemaster39):

                                # this is required to handle pathlib oddity on win32 python==3.5
                                path = lib.joinpath(path)
                        paths.add(path)

        src_path = env.path / "src" / name
        if not paths and src_path.exists():
            paths.add(src_path)

        return paths

    @classmethod

[mrtolkien]

The 1.2 preview crashes for me, but this hotfix works perfectly on 1.1.8. Thanks for sharing it!

[phillipuniverse]

The workaround that @Ivorforce worked for me but I was using the legacy installer and the file to patch is at ~/.poetry/lib/poetry/repositories/installed_repository.py.

[PabloCastellano]

This is still happening to me on 1.1.12. How can we move this forward?

I tried @Ivorforce workaround but it's not perfect, since all git dependencies are cloned even if the version has not changed:

Check these results:

1. Without the workaround

$ poetry install
Installing dependencies from lock file

No dependencies to install or update

2. After applying the workaround

$ poetry install
Installing dependencies from lock file

Package operations: 0 installs, 5 updates, 0 removals

  • Updating dj-stripe (2.5.1 0d22b4e -> 2.5.1 de40328)
  • Updating django-bootstrap-scss-static (4.5.3 c4a1291 -> 4.5.3 c4a1291)
  • Updating django-daterangefilter (1.0.0 f1a4339 -> 1.0.0 f1a4339)
  • Updating django-tailwind (3.1.1 d340149 -> 3.1.1 d340149)
  • Updating pyswagger (0.8.39 7b15c12 -> 0.8.39 7b15c12)

It worked! But I only expected to update dj-stripe. And from the results it was indeed the only one that updated the version.

But what happens if I run it again?

$ poetry install
Installing dependencies from lock file

Package operations: 0 installs, 5 updates, 0 removals

  • Updating dj-stripe (2.5.1 de40328 -> 2.5.1 de40328)
  • Updating django-bootstrap-scss-static (4.5.3 c4a1291 -> 4.5.3 c4a1291)
  • Updating django-daterangefilter (1.0.0 f1a4339 -> 1.0.0 f1a4339)
  • Updating django-tailwind (3.1.1 d340149 -> 3.1.1 d340149)
  • Updating pyswagger (0.8.39 7b15c12 -> 0.8.39 7b15c12)

What? So all git dependencies are updated even if the version didn't change 🤔

as a quick workaround

• remove the depdendency,
• runnin poetry install
• add it again
• runpoetry install

[jessielaf]

Is there an update on this issue?

[evdevdev]

I can confirm this issue is still present. Is there anything I can do to help document its reproducibility and/or help with implementing a fix?