tests: adapt tests to cosmetic changes caused by poetry-core#826#10110
tests: adapt tests to cosmetic changes caused by poetry-core#826#10110abn merged 1 commit intopython-poetry:mainfrom
Conversation
Reviewer's Guide by SourceryThis pull request adapts tests to cosmetic changes caused by poetry-core#826. The changes involve updating the expected output of the tests to match the new format of the dependency markers generated by poetry-core. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey @radoering - I've reviewed your changes - here's some feedback:
Overall Comments:
- Using a personal fork of poetry-core could cause maintenance issues. What's the timeline for getting these changes merged upstream into python-poetry/poetry-core?
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| ], | ||
| ) | ||
| opencv_requires = {dep.to_pep_508() for dep in ops[-1].package.requires} | ||
| expectation = ( |
There was a problem hiding this comment.
Notably, I removed the distinction between "concise solution" and "current solution" because we have reached a solution which is even more concise than the "concise solution".
1007cfe to
b916a2a
Compare
b916a2a to
d9a6b81
Compare
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
see issue title
The
poetry-plugin-exportfailures are caused by cosmetic changes. The tests are fixed in python-poetry/poetry-plugin-export#321. We should probably merge this PR with failing downstream tests and switch from the released poetry-core version to the main branch afterwards. (I changed the CI to use the main branch ofpoetry-plugin-exportinstead the latest release.)Summary by Sourcery
Tests: