Skip to content

executor: propagate original error even if pkg.to_dependency() fails #10340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lotheac wants to merge 1 commit into from
Closed

executor: propagate original error even if pkg.to_dependency() fails #10340

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions src/poetry/installation/executor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
from __future__ import annotations

import contextlib
import csv
import functools
import itertools
Expand Down Expand Up @@ -326,13 +327,17 @@ def _execute_operation(self, operation: Operation) -> None:
# we disable trace here explicitly to workaround incorrect context detection by crashtest
with_trace = False
pip_command = "pip wheel --no-cache-dir --use-pep517"
requirement = pkg.source_url
if pkg.develop:
requirement = pkg.source_url
pip_command += " --editable"
else:
requirement = (
pkg.to_dependency().to_pep_508().split(";")[0].strip()
)
with contextlib.suppress(ValueError):
requirement = (
pkg.to_dependency()
.to_pep_508()
.split(";")[0]
.strip()
)

if config_settings := self._build_config_settings.get(pkg.name):
for setting in config_settings:
Expand Down
Loading