Skip to content

tests: make test forward compatible with poetry-core#893#10605

Merged
radoering merged 1 commit intopython-poetry:mainfrom
radoering:tests/forward-compat-version-normalization
Oct 31, 2025
Merged

tests: make test forward compatible with poetry-core#893#10605
radoering merged 1 commit intopython-poetry:mainfrom
radoering:tests/forward-compat-version-normalization

Conversation

@radoering
Copy link
Copy Markdown
Member

@radoering radoering commented Oct 31, 2025

python-poetry/poetry-core#893 normalizes versions. The focus of the test is not on unnormalized versions. It is probably just coincidence that an unnormalized version is used.

(poetry-core#893 normalizes versions. The focus of the test is not on unnormalized versions. It is probably just coincidence that an unnormalized version is used.)
@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Oct 31, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Update test expectations to use normalized version strings, replacing ‘2.0.b0’ with ‘2.0b0’ for forward compatibility with poetry-core#893.

File-Level Changes

Change Details Files
Normalize version literals in test cases
  • Replace package addition from '2.0.b0' to '2.0b0'
  • Update expected results in test_find_packages_allow_prereleases to use '2.0b0'
tests/repositories/test_repository.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@radoering radoering merged commit 477b54b into python-poetry:main Oct 31, 2025
63 checks passed
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 1, 2025

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Dec 1, 2025
@radoering radoering deleted the tests/forward-compat-version-normalization branch December 13, 2025 17:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant