dulwich: remove redundant encode#10675
Merged
Merged
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates Git backend and integration tests to stop encoding the path argument when calling dulwich’s fetch API, reflecting that dulwich 0.25.0 now expects a str rather than bytes. Sequence diagram for Git fetch using dulwich 0.25.0 without encodesequenceDiagram
participant PoetryGitBackend
participant DulwichClient
participant LocalRepo
PoetryGitBackend->>LocalRepo: open context manager
activate LocalRepo
PoetryGitBackend->>DulwichClient: fetch(path, LocalRepo, determine_wants_all)
activate DulwichClient
note over DulwichClient: path is now str (no encode)
DulwichClient->>LocalRepo: determine_wants_all
DulwichClient->>LocalRepo: update object_store
DulwichClient-->>PoetryGitBackend: FetchPackResult
deactivate DulwichClient
PoetryGitBackend->>LocalRepo: close context manager
deactivate LocalRepo
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Secrus
approved these changes
Dec 30, 2025
75e4017 to
182769e
Compare
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
minor addition regarding #10674
The
encode()was necessary with dulwich 0.24.10, but is not anymore with dulwich 0.25.0. See jelmer/dulwich#2036Summary by Sourcery
Enhancements: