Skip to content

fix(constraints): Pass along pre-release in all cases#1152

Closed
epage wants to merge 1 commit into
python-poetry:masterfrom
epage:pre
Closed

fix(constraints): Pass along pre-release in all cases#1152
epage wants to merge 1 commit into
python-poetry:masterfrom
epage:pre

Conversation

@epage
Copy link
Copy Markdown
Contributor

@epage epage commented Jun 5, 2019

Fixes #1150

Pull Request Check List

This is just a reminder about the most common mistakes. Please make sure that you tick all appropriate boxes. But please read our contribution guide at least once, it will save you unnecessary review cycles!

  • Added tests for changed code.
  • Updated documentation for changed code. N/A

Note: If your Pull Request introduces a new feature or changes the current behavior, it should be based
on the develop branch. If it's a bug fix or only a documentation update, it should be based on the master branch.

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

@epage
Copy link
Copy Markdown
Contributor Author

epage commented Jun 5, 2019

I didn't see direct tests for this function so I was unsure what is the appropriate way of testing it.

EDIT: nm, found it and adding some

@epage
Copy link
Copy Markdown
Contributor Author

epage commented Jun 6, 2019

Tests are now added

@epage
Copy link
Copy Markdown
Contributor Author

epage commented Jun 6, 2019

@drunkwcodes could you clarify your thumbs down?

@drunkwcodes
Copy link
Copy Markdown

It's a non-issue because of the occurence of #1153.

@brycedrennan brycedrennan added the kind/bug Something isn't working as expected label Aug 17, 2019
@stale
Copy link
Copy Markdown

stale Bot commented Nov 13, 2019

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale Bot added the stale label Nov 13, 2019
@epage
Copy link
Copy Markdown
Contributor Author

epage commented Nov 13, 2019

So while part of the problem was fixed in #1481, this problem still exists while this PR has been getting no attention from the maintainers. Do I bother resolving the conflicts or do I let the rudely applied bots close this?

@stale stale Bot removed the stale label Nov 13, 2019
@finswimmer
Copy link
Copy Markdown
Member

Hey @epage,

So while part of the problem was fixed in #1481, this problem still exists [...]

could you please add some more details about what problem still exists?

Thanks a lot!

fin swimmer

@epage
Copy link
Copy Markdown
Contributor Author

epage commented Feb 19, 2020

could you please add some more details about what problem still exists?

#1481 claimed to fix ~= but missed the case covered here: pre-release constraints.

@abn
Copy link
Copy Markdown
Member

abn commented Oct 24, 2020

The relevant code in this PR has moved to poetry-core. This change, if still required, should be opened there.

@abn abn closed this Oct 24, 2020
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 1, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

kind/bug Something isn't working as expected

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pre-release ~= constrains are mis calculated

5 participants