Run command initialize() in order to ensure that directory structures are created#1180
Closed
hozn wants to merge 2 commits intopython-poetry:developfrom
Closed
Run command initialize() in order to ensure that directory structures are created#1180hozn wants to merge 2 commits intopython-poetry:developfrom
hozn wants to merge 2 commits intopython-poetry:developfrom
Conversation
…rs and templates created.
brycedrennan
suggested changes
Aug 17, 2019
Contributor
brycedrennan
left a comment
brycedrennan
left a comment
There was a problem hiding this comment.
@hozn thanks for contributing! Could you please rebase off of latest develop and squash your two commits together?
Author
|
I am away from technology for awhile, but can check back on this in a
couple weeks.
|
Member
|
The |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the update the Cleo 0.7.x (https://github.com/sdispater/cleo/blob/master/CHANGELOG.md) the
initialize()method ofConfigCommandwas no longer being called by the superclass. This PR just calls it explicitly fromhandle()in order to ensure that the directories are created. Also adds a test to ensure that this functionality works correctly.