Extract method - Git._folder_args#1269
Closed
dazza-codes wants to merge 1 commit into
Closed
Conversation
This was referenced Jul 31, 2019
brycedrennan
approved these changes
Aug 9, 2019
dazza-codes
force-pushed
the
git-folder-args-extract
branch
from
3938282 to
1f4a482
Compare
dazza-codes
force-pushed
the
git-folder-args-extract
branch
from
1f4a482 to
7aa5eac
Compare
Contributor
Author
|
PRs are moving very slowly, any plans to merge this?
|
dazza-codes
force-pushed
the
git-folder-args-extract
branch
from
7aa5eac to
eb14d89
Compare
Contributor
Author
|
dazza-codes
force-pushed
the
git-folder-args-extract
branch
from
eb14d89 to
a2b90bf
Compare
Contributor
Author
|
rebased on latest develop after master was merged in
|
dazza-codes
force-pushed
the
git-folder-args-extract
branch
from
a2b90bf to
3ce58fd
Compare
Contributor
Author
|
Is anyone going to merge this? |
Member
|
Hi! Sorry that this has taken so long to review! Unfortunately, there's been enough churn that this is now totally obsolete. I'm closing this, but if you still want to work on/around this aspect of Poetry you are more than welcome to! |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pure extract-method refactor
checklist