Skip to content

Fix support for url sourced packages in pip installer #1306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sdispater merged 1 commit into from
Sep 3, 2019
Merged

Fix support for url sourced packages in pip installer #1306

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions poetry/installation/pip_installer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,9 @@ def requirement(self, package, formatted=False):
package.source_url, package.source_reference, package.name
)

if package.source_type == "url":
return "{}#egg={}".format(package.source_url, package.name)

return "{}=={}".format(package.name, package.version)

def create_temporary_requirement(self, package):
Expand Down
13 changes: 13 additions & 0 deletions tests/installation/test_pip_installer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,19 @@ def test_requirement():
assert expected == result


def test_requirement_source_type_url():
installer = PipInstaller(NullEnv(), NullIO(), Pool())

foo = Package("foo", "0.0.0")
foo.source_type = "url"
foo.source_url = "https://somehwere.com/releases/foo-1.0.0.tar.gz"

result = installer.requirement(foo, formatted=True)
expected = "{}#egg={}".format(foo.source_url, foo.name)

assert expected == result


def test_install_with_non_pypi_default_repository():
pool = Pool()

Expand Down