Skip to content

Respect Python version in bin script #1312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
michielboekhoff wants to merge 2 commits into from
Closed

Respect Python version in bin script #1312

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c967ae6
Respect installing Python version in bin script.
michielboekhoff Aug 21, 2019
8f04f63
Document Python version used by poetry binary.
michielboekhoff Aug 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ It supports Python 2.7 and 3.4+.

Poetry provides a custom installer that will install `poetry` isolated
from the rest of your system by vendorizing its dependencies. This is the
recommended way of installing `poetry`.
recommended way of installing `poetry`. The installer installs a script to run Poetry, which will use the version of Python used to install Poetry.

```bash
curl -sSL https://raw.githubusercontent.com/sdispater/poetry/master/get-poetry.py | python
Expand Down
8 changes: 5 additions & 3 deletions get-poetry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ def expanduser(path):
POETRY_LIB_BACKUP = os.path.join(POETRY_HOME, "lib-backup")


BIN = """#!/usr/bin/env python
BIN_TEMPLATE = """#!/usr/bin/env {python_executable_name}
# -*- coding: utf-8 -*-
import glob
import sys
Expand Down Expand Up @@ -580,8 +580,10 @@ def make_bin(self):
)

with open(os.path.join(POETRY_BIN, "poetry"), "w", encoding="utf-8") as f:
f.write(u(BIN))

python_executable_name = os.path.basename(Installer.CURRENT_PYTHON)
f.write(
u(BIN_TEMPLATE.format(python_executable_name=python_executable_name))
)
if not WINDOWS:
# Making the file executable
st = os.stat(os.path.join(POETRY_BIN, "poetry"))
Expand Down