Fix broken port regex#1560
Closed
iwoloschin wants to merge 1 commit into
Closed
Conversation
sdispater
requested changes
Nov 10, 2019
Member
sdispater
left a comment
sdispater
left a comment
There was a problem hiding this comment.
Thanks for your contribution!
Could you add a test covering this fix?
Author
|
I'll give it a shot, might take a couple of days. If the next release will be sooner please let me know. |
Member
|
Closing this since the error was not in the format of the git url, in the end. See #1576 for the actual fix. Thanks for your contribution. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1557.