Skip to content

fix: Add information about valid export formats to help page#1653

Merged
kasteph merged 1 commit into
python-poetry:masterfrom
finswimmer:issue-01640-export-help
Mar 29, 2020
Merged

fix: Add information about valid export formats to help page#1653
kasteph merged 1 commit into
python-poetry:masterfrom
finswimmer:issue-01640-export-help

Conversation

@finswimmer
Copy link
Copy Markdown
Member

Add missing information about valid export formats to help page.

Fixes: #1640

Pull Request Check List

This is just a reminder about the most common mistakes. Please make sure that you tick all appropriate boxes. But please read our contribution guide at least once, it will save you unnecessary review cycles!

  • Added tests for changed code.
  • Updated documentation for changed code.

@finswimmer finswimmer requested a review from kasteph November 30, 2019 11:45
@finswimmer finswimmer requested review from a team and removed request for kasteph December 13, 2019 17:42
@finswimmer finswimmer added the area/docs Documentation issues/improvements label Dec 13, 2019
@AngelOnFira
Copy link
Copy Markdown

@finswimmer I think it might be a good idea to change the message to:

Format to export to (requirement.txt)

When I was trying this command for the first time, I tried

poetry export -f pip -o requirements.txt
poetry export -f requirements -o requirements.txt

before arriving at the right solution. I think explicitly stating the options is more helpful than saying that it's the only one.

Copy link
Copy Markdown
Member

@kasteph kasteph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🤖

@kasteph kasteph merged commit 9e1324e into python-poetry:master Mar 29, 2020
@finswimmer finswimmer deleted the issue-01640-export-help branch April 4, 2020 19:01
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 1, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area/docs Documentation issues/improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

poetry export help doesn't provide the format options

3 participants