Work around for --no-deps failure in pip

[wakemaster39]

I am not sure about the checklist, I went looking at the unit tests and there is no coverage for this area of the pip_installer so not sure where I should be targeting to start with that.

I don't think this needs to be documented as it should all be invisible in the background but maybe we want something visible so users know it is messing around like this?

I also wasn't sure as this changes behaviour but it is also a bug fix. I can close and resubmit if it is preferred against the develop branch. I am impacted by this issue now so I treated it as a bug.

This should resolve #1689

Pull Request Check List

This is just a reminder about the most common mistakes. Please make sure that you tick all appropriate boxes. But please read our contribution guide at least once, it will save you unnecessary review cycles!

• Added tests for changed code.
• Updated documentation for changed code.

Note: If your Pull Request introduces a new feature or changes the current behavior, it should be based
on the develop branch. If it's a bug fix or only a documentation update, it should be based on the master branch.

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

[finswimmer]

Whoooah, thanks a lot! 🚀 🎸

This one was making me headache the last days. I have already found out, that it has something to do with pip but not what goes wrong exactly.

I'm not sure if it is a good idea to rename the pyproject.toml to something cryptic. There might be cases where the reverting to pyproject.toml doesn't work. So I would prefer something like pyproject.toml.orig or similar. (There's a good chance, that the file already exists). So maybe we can append/prepend something cryptic to the filename?

fin swimmer

[wakemaster39]

happy to do an append or whatever makes the most sense here, I typically don't see guids in my code base so I would know what I am looking for. It is also that way to avoid the collision, but appending to the file name would also solve this.

[wakemaster39]

This is a hack, I don't think this should be merged in but I will leave it here if I can't find a better alternative. I will link the information I have found in the issue and try and see if I can come up with a proper fix.

[finswimmer]

Hello @wakemaster39 ,

yes this is a workaround and I would like to see a proper solution instead just like you. Thanks for your investigations and informations in the issue! I hope @sdispater has also some time to look at this.

What works for me in the meantime, is to make sure that within the venv the pip version is <19.

[kalyangvs]

When would this be merged into master?

[finswimmer]

Hey @gvskalyan,

it is unclear if this ever get merged, because this is "just" a hack and not a clean solution for the underlying problem. See also #1689.

@sdispater has to decide.

[wakemaster39]

superseded by #1875

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.