Prevent empty parentheses from appearing in lockfile marker#1801
Closed
oliver-charlesworth wants to merge 1 commit into
Closed
Prevent empty parentheses from appearing in lockfile marker#1801oliver-charlesworth wants to merge 1 commit into
oliver-charlesworth wants to merge 1 commit into
Conversation
Member
|
Hey @oliver-charlesworth, thanks a lot for your contribution 👍 It looks like this is superseded by #2361 in the meantime. Feel free to leave a comment if you disagree. fin swimmer |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1728.
Fixes #1772.
Prior to this PR, an extra dependency of the form:
would be serialised to the lockfile as:
Per #1728, the lockfile parser crashes on this.
This PR fixes that.
So far as I can tell this needs to be fixed on the serialisation side - empty parentheses are not permitted by the PEP 508 grammar.
The fix is implemented by updating
MultiMarker.__str__to filter out any/empty markers (which occur whenwith_extras=False), similarly to the existing behaviour ofMarkerUnion.__str__.I'd like to add more defensive test coverage for the various
MarkerXyzclasses, but I'll do that in a follow-up PR.