Fix missing URL source option for multi-constraint dependencies#1819
Closed
veloxo wants to merge 2 commits intopython-poetry:masterfrom
veloxo:fix-multi-constraints-add-url-dependency
Closed
Fix missing URL source option for multi-constraint dependencies#1819veloxo wants to merge 2 commits intopython-poetry:masterfrom veloxo:fix-multi-constraints-add-url-dependency
veloxo wants to merge 2 commits intopython-poetry:masterfrom
veloxo:fix-multi-constraints-add-url-dependency
Conversation
|
Thanks! This PR fixes a real blocker I have, preventing me from installing pytorch on Linux & Windows. I hope it's going to be merged soon |
finswimmer
approved these changes
Feb 6, 2020
Member
finswimmer
left a comment
finswimmer
left a comment
There was a problem hiding this comment.
LGTM 👍
Thanks a lot for your contribution!
Member
|
Thanks for your contribution! However, #2035, which fixes the same issue, has already been merged. So I am closing this PR. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the schema to allow URL sources in multi-constraint dependencies. Looks like a minor oversight when url-dependencies were added in #1260.
Updated documentation for changed code.N/A