self.run("clone", "--recurse-submodules", repository, str(dest))#1826
Closed
matemax wants to merge 1 commit into
Closed
self.run("clone", "--recurse-submodules", repository, str(dest))#1826matemax wants to merge 1 commit into
matemax wants to merge 1 commit into
Conversation
3 tasks
Contributor
Author
|
closes #1828 |
Contributor
Author
|
@finswimmer, i don`t know that this PR ready for review or not because i not found tests which checking a correct repo cloning and docs about clone strategy. |
Contributor
Author
|
@sdispater tell me pleaze what should i do yet in it PR? |
Contributor
Author
|
Is there any news? |
Contributor
Author
|
@sdispater, is there any question, suggestions? |
Contributor
Author
|
@finswimmer , @sdispater, Sorry guys, this feature is very helpful for me. What should i do for accepting this PR? |
Member
|
Hello @matemax, @sdispater needs to find some time for reviewing and merging it 😃 fin swimmer |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #1828
Closes: #611
Pull Request Check List
I not found how implement test for these case
I not found docs about clone git dependencies.