Skip to content

clarify wildcard dependency specification#2229

Merged
kasteph merged 1 commit into
python-poetry:masterfrom
euven:clarify-wildcard-dependency-spec
Mar 29, 2020
Merged

clarify wildcard dependency specification#2229
kasteph merged 1 commit into
python-poetry:masterfrom
euven:clarify-wildcard-dependency-spec

Conversation

@euven
Copy link
Copy Markdown
Contributor

@euven euven commented Mar 26, 2020

Pull Request Check List

This is just a reminder about the most common mistakes. Please make sure that you tick all appropriate boxes. But please read our contribution guide at least once, it will save you unnecessary review cycles!

  • Added tests for changed code.
  • Updated documentation for changed code.

Note: If your Pull Request introduces a new feature or changes the current behavior, it should be based
on the develop branch. If it's a bug fix or only a documentation update, it should be based on the master branch.

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

@ulgens
Copy link
Copy Markdown

ulgens commented Mar 26, 2020

I'm not sure "latest" is the correct word. It may not be the latest, depending on other packages in the file.

@euven euven force-pushed the clarify-wildcard-dependency-spec branch from 8ad414a to 53fa122 Compare March 27, 2020 02:01
@euven
Copy link
Copy Markdown
Contributor Author

euven commented Mar 27, 2020

Thanks @ulgens - I've changed the wording there. Let me know what you think or if you have a better suggestion.

@finswimmer finswimmer added the area/docs Documentation issues/improvements label Mar 27, 2020
@finswimmer finswimmer requested a review from a team March 27, 2020 14:19
Copy link
Copy Markdown
Member

@kasteph kasteph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! ✨

@kasteph kasteph merged commit fb4628c into python-poetry:master Mar 29, 2020
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 1, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area/docs Documentation issues/improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants