Fix requirement string parsing for URLs#2344
Closed
simonepri wants to merge 1 commit into
Closed
Conversation
Member
|
@simonepri looks like this also will affect Also, would be great to get this also submitted to python-poetry/core, since this will need to be fixed for |
abn
requested changes
Apr 25, 2020
Member
abn
left a comment
abn
left a comment
There was a problem hiding this comment.
Can you add some test coverage for this so we do not regress on this one?
Contributor
Author
|
@abn Which regex shall we use as a fix? |
Member
|
@simonepri see #2326 (comment) I think we can fix this in the utils. |
Contributor
Author
|
Closing in favour of python-poetry/poetry-core#30 and #2349 |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #2326
If we want support url containing the
;character, we can use the following regex instead:((?!; )(?!;^)(?! ).)+