Fix editable installations for Poetry packages#2400
Merged
Conversation
abn
requested changes
May 10, 2020
sdispater
force-pushed
the
fix-editable-installs
branch
from
241c5dd to
90d2941
Compare
abn
approved these changes
May 15, 2020
Member
abn
left a comment
abn
left a comment
There was a problem hiding this comment.
One (optional) recommendation. Otherwise, lgtm.
Contributor
|
@sdispater Anything left to do here? I'd love to give this a spin. |
3 tasks
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
Followup to #2360
Basically, editable installs for transitive packages failed due to the
build_scriptattribute not being available on standardPackageobjects.Also, the generated scripts weren't correct if the callable was a module attribute.
Finally, the loading of editable installed packages was not correct and they weren't marked as being directory dependencies which would lead to them being always updated when installing.
Note that we will rely on PEP 610 in the future for detection of such packages.