Fix regression where package.source_reference is unset#2460
Closed
dan-hipschman wants to merge 1 commit intopython-poetry:developfrom
Closed
Fix regression where package.source_reference is unset#2460dan-hipschman wants to merge 1 commit intopython-poetry:developfrom
dan-hipschman wants to merge 1 commit intopython-poetry:developfrom
Conversation
Author
|
It looks like the bug this PR addresses was fixed by #2484. I'll close this PR. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
This fixes an issue that looks like it's a regression on the develop branch.
The problem occurs with packages from private repos:
It's caused by
source_referencenot being set in the lock file.In lockfile on master:
In lockfile on develop:
It was removed in this change. This PR just adds it back with a test.
Pull Request Check List
Resolves: I didn't file an issue for this because it's only on the develop branch, not master.
Updated documentation for changed code.(bug fix)