Add system-site-packages setting (rebased)

[wyl8899]

This PR is a rebase of #1982 by @kam1sh , making necessary changes to make the tests pass.

Please let me know if things are missing or need to be done. Thank you!

Pull Request Check List

Resolves: #1393

• Added tests for changed code.
• Updated documentation for changed code.

[abn]

@wyl8899 assuming @kam1sh has not responded please see #1982 (comment)

[wyl8899]

Sure, I will take a stab.

[wyl8899]

@abn Done! Could you please take a look?

I don't quite like the fact that assert_called_with... flags={"always-copy": False, "system-site-packages": False} checks are everywhere, though. Maybe it could be done better.

[abn]

One minor change; otherwise looking good.

I agree we should make sure that we keep the defaults DRY when testing. Maybe another PR to do just that? :)

[wyl8899]

Suggestions applied and squashed. Thanks!

[abn]

This will need a rebase since a new boolean config was added in 1.1.4.

[abn]

Changes look good. Rebase required.

[jmahlik]

Any updates on this, looks sooo close :) ? This would be a much loved feature vs. scripting changes to the .venv/pyvenv.cfg.

[wyl8899]

Oops, totally forgot about this. (I use script to change pyvenv.cfg at $dayjob too.)

Let me do another rebase.

[wyl8899]

@abn Could you please take a look?

[jmahlik]

Not sure if this is related to poetry specifically but thought I'd mention it here to make sure it is accounted for.

When you have a package in the virtual env and that same package in your system site packages, poetry update will try to overwrite the package installed in the system site packages, which (on windows) produces the following (which it should IMO):

ERROR: Could not install packages due to an EnvironmentError: [WinError 5] Access is denied:

This specifically happened for the regex dependency of black for me. So it doesn't look like it tries to overwrite the system packages all the time, because black itself successfully updated.

Manually edited the .venv/pyvenv.cfg to include-system-site-packages = true

Not sure if this could be accounted for in the way poetry is updating packages with this option enabled. If so, great, if not, the docs should mention running this option might cause issues on poetry update.

Again, I'm not sure this is a poetry issue, but just wanted to get this out here.

[abn]

Resolved via #3711 and #3817

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.