repository/legacy: calculate sha256 if unavailable#2958
Merged
kasteph merged 1 commit intopython-poetry:masterfrom Mar 22, 2021
Merged
repository/legacy: calculate sha256 if unavailable#2958kasteph merged 1 commit intopython-poetry:masterfrom
kasteph merged 1 commit intopython-poetry:masterfrom
Conversation
|
Hey @abn, when is this slotted to be released? Is there a beta with this functionality that I can test with? |
|
nvm. i just did |
Member
Author
|
No fixed plans; the release after when this is reviewed as this is not in the roadmap explicitly. |
Member
Author
|
@finswimmer can you take a peek at this? |
In some cases, legacy repositories might not provide a checksum as a url fragment or use a deprecated algorithm. In these scenarios, this change ensures that poetry downloads and calculates the sha256 checksum for the file. Resolves: python-poetry#1631 python-poetry#1553
kasteph
approved these changes
Mar 22, 2021
3 tasks
3 tasks
|
Hi! Is it possible this change could have caused a regression when installing from legacy repositories which return md5 checksums? #4085 (comment) |
Closed
2 tasks
Closed
3 tasks
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some cases, legacy repositories might not provide a checksum as a
url fragment or use a deprecated algorithm. In these scenarios, this
change ensures that poetry downloads and calculates the sha256 checksum
for the file.
Resolves: #1631 #1553