Prefer 'python3' executables over 'python' during install#3701
Merged
Conversation
orf
changed the title
|
I hope this gets merged - I was nearly put off using poetry when the recommended install method defaulted to python2 on macOS. This seems like a no brainer |
Member
|
The |
abn
approved these changes
Mar 28, 2021
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the setup script uses
pythonfirst, and falls back topython3. This means python2 is often picked up on systems that have Python3 installed.This MR swiches the check order to use
python3first, thenpython.In the future when Poetry drops python2 support, without this change the install script will be broken on any system that has Python2 installed as
python, regardless ofpython3being present.