refactor(test_env, conftest): move default venv flags to fixture#3836
Merged
Secrus merged 4 commits intoMay 22, 2023
Merged
Conversation
vlad0337187
force-pushed
the
refactor/tests-move-default-venv-flags-to-fixtures
branch
from
7c92a77 to
d7e2ce8
Compare
Contributor
Author
|
@abn , hello, did a little refactor, hope, that's what you wanted in you comment. Thanks. Failing stages aren't related to current changes. |
vlad0337187
changed the title
abn
previously requested changes
Mar 27, 2021
Member
abn
left a comment
abn
left a comment
There was a problem hiding this comment.
LGTM. Thanks @vlad0337187. Can you do a rebase on master please? That should resovle the failures I reckon.
vlad0337187
force-pushed
the
refactor/tests-move-default-venv-flags-to-fixtures
branch
2 times, most recently
from
4328c6a to
a99ecef
Compare
Contributor
Author
|
@abn , rebased, seems now all is good. |
neersighted
force-pushed
the
refactor/tests-move-default-venv-flags-to-fixtures
branch
from
a99ecef to
26051db
Compare
neersighted
force-pushed
the
refactor/tests-move-default-venv-flags-to-fixtures
branch
from
26051db to
ae9c459
Compare
Member
|
Rebased, but still broken thanks to a broken |
Member
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
Secrus
approved these changes
May 22, 2023
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
Resolves: suggestion to make code more clear in merged PR