replace f-string in get-poetry by .format() for python2 compatibility#4138
Merged
sdispater merged 1 commit intoJun 4, 2021
Merged
Conversation
finswimmer
force-pushed
the
issue/4131-get-poetry-f-string
branch
from
0a01882 to
5d0faf9
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
sdispater
approved these changes
Jun 4, 2021
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
c28728f introduces f-strings in
get-poetry.py. Because this script is intended to run in python2 as well, f-strings must be replaced by.format()Resolves: #4131