Fix installing under MinGW on Windows#4467
Closed
s0600204 wants to merge 3 commits into
Closed
Conversation
python, when installed via (msys) MingW on Windows, can be found under a path structure similar to that you might find on *nix systems. The install-poetry.py script was failing to take this into consideration, causing installation issues winth Windows + MingW. A similar fault in poetry itself was resolved in python-poetry#3713.
s0600204
changed the title
abn
requested changes
Oct 8, 2021
As suggested by @abn (Requires python 3.6, which is to be the minimum for the poetry 1.2 release.)
Member
|
I am not sure when we will migrate them back to this repo, but given the canonical source has moved, that will be the best place to send your PR. |
Contributor
Author
|
Ok, noted. Thanks for the information. |
1 task
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
python[.exe], when installed on Windows via (msys2) MingW, can be found under a path structure similar to that you might find on *nix systems.The
install-poetry.pyscript was failing to take this into consideration, causing installation issues in the above case.A similar fault in poetry itself was resolved in #3713.
Pull Request Check List
Related: #2867, #3713
install-poetry.py(except the CI run).