Sanitize installation paths on Windows#4651
Closed
f0ff886f wants to merge 1 commit into
Closed
Conversation
This was referenced Oct 18, 2021
Author
|
The failed tests seem to have failed for environment reasons (ConnectionResetByPeer), not sure how to rerun them. https://cirrus-ci.com/task/5416883047366656 |
Author
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
Resolves: #4163
I'm starting a PR for 4163 as it hits many Windows users and results in a broken poetry. I'm reusing fixes from the issue and would be happy to fix up the PR with tests if someone could point how to properly test this behaviour on Windows.