Forward compatibility for multiple readme files#4781
Closed
wagnerluis1982 wants to merge 1 commit into
Closed
Conversation
This makes poetry aware about the upcoming changes in poetry-core in order to support declaration of multiple readme files in pyproject.toml Relates #873 Enable python-poetry/poetry-core#248
2 tasks
neersighted
approved these changes
Nov 17, 2021
abn
reviewed
Nov 18, 2021
| assert package.license.id == "MIT" | ||
| assert ( | ||
| package.readme.relative_to(fixtures_dir).as_posix() | ||
| single_readme.relative_to(fixtures_dir).as_posix() |
Member
There was a problem hiding this comment.
Suggested change
| single_readme.relative_to(fixtures_dir).as_posix() | |
| # coment indicating why | |
| getattr(package, "readmes", [package.readme]).relative_to(fixtures_dir).as_posix() |
Contributor
Author
|
Closing as python-poetry/poetry-core#248 went into other direction, by ensuring retrocompatibiity. |
wagnerluis1982
deleted the
forward-compatibility-multiple-readme-files
branch
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes poetry aware about the upcoming changes in python-poetry/poetry-core#248 in order to support declaration of multiple readme files in pyproject.toml
Relates: #873