fix: git subdirectory dependencies fail to resolve with a TypeError on name#4922
Closed
steved wants to merge 2 commits into
Closed
fix: git subdirectory dependencies fail to resolve with a TypeError on name#4922steved wants to merge 2 commits into
steved wants to merge 2 commits into
Conversation
FAILED tests/puzzle/test_provider.py::test_search_for_vcs_hyphenated_name - TypeError: expected string or bytes-like object
Author
|
cc @sdispater |
2 tasks
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
Resolves: #4678
This is an attempt to create a fix and test for #4678 where the addition of subdirectory support for Git repositories (python-poetry/poetry-core#192) does seem to require some added code for package name discovery. The error manifests as the TypeError in the associated issue when creating a Git dependency with a subdirectory (hyphen actually ends up not mattering).
I'm having trouble creating a clean unit test, however, as the bug is actually partially in the
_pep517_metadatamethod that is entirely mocked out. There may be a way to craft anUNKNOWN.egg-infodirectory instead, but some direction for a better test would be helpful.