Fix asking for username/password in Publisher

[NiklasRosenstein]

Fixes #4790

Somewhere between Cleo 0.8.0 and 1.0.0a4, the IO.ask() and IO.ask_hidden() methods were removed. I added Publisher.ask() which is almost equivalent to Cleo's Command.ask(), only that it also accepts a hidden argument.

[NiklasRosenstein]

Hey @neersighted , what do you think of it now?

[NiklasRosenstein]

Pinging @radoering as the last committer on Poetry hoping to get some momentum in here. 🙃

[radoering]

Two remarks:

1. Is there a reason why the import of Question is local?
2. I wonder if it is feasible to write a test in order to detect possible API changes in the future?

[neersighted]

Hey @neersighted , what do you think of it now?

Sorry, fell down the work hole -- I think @radoering should be able to get you over the finish line :)

[branchv]

@NiklasRosenstein sorry for the long back and forth, are you still interested in finishing this out with a test? You could follow the examples using inputs from test_init.py

No worries if not, I can help with this last step

[dimbleby]

Just spotted this after #5889 was merged. In that MR I removed this code altogether - which certainly fixes the bug that you were hitting.

Do you actually care about asking for username and password here? IMO if this is to happen it would be better on the Command, but deleting the code seems satisfactory to me, the command line accepts --password and --username already and I don't see any compelling reason to treat just these two parameters on just this one command exceptionally.

(Also this has been broken for so long that it's clear that no-one has been using the function!)

[neersighted]

Just spotted this after #5889 was merged. In that MR I removed this code altogether - which certainly fixes the bug that you were hitting.

Do you actually care about asking for username and password here? IMO if this is to happen it would be better on the Command, but deleting the code seems satisfactory to me, the command line accepts --password and --username already and I don't see any compelling reason to treat just these two parameters on just this one command exceptionally.

(Also this has been broken for so long that it's clear that no-one has been using the function!)

I merged that PR in light of this one existing / planning to circle back to it. I do think that the interactive credential support is an anti-pattern and that given we've greatly improved support for non-interactive credentials there is no more need for it. Combine that with adaptation to newer Cleo versions being kludgy and I don't particular care to resurrect it.

That being said, @NiklasRosenstein if you disagree, please feel free to post a new version of this patch/re-open this PR, especially if you can come up with a more elegant design. @dimbleby's input looks good to me.

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.