Skip to content

Port #4086 to 1.1 branch#5200

Closed
robin92 wants to merge 3 commits into
python-poetry:1.1from
robin92:fix/port-PR-4086-to-1.1
Closed

Port #4086 to 1.1 branch#5200
robin92 wants to merge 3 commits into
python-poetry:1.1from
robin92:fix/port-PR-4086-to-1.1

Conversation

@robin92
Copy link
Copy Markdown

@robin92 robin92 commented Feb 15, 2022

Resolves: #3216

  • Added tests for changed code.
  • Updated documentation for changed code.

@robin92
Copy link
Copy Markdown
Author

robin92 commented Feb 15, 2022

Poetry 1.1.13 has issues with downloading packages from private PyPI servers hosted on Azure Artifacts. Problem manifests with a HTTP 401 Unauthorized error and seems to already have been reported and handled by #4086. However, that PR targets the master branch and next feature release but users of current stable releases are left with effectively no access to Azure Artifacts.

This PR ports the change made by @Darsstar to 1.1 branch along with some pip.py file and ephemeral_environment function from other commits (dependencies). This change has been tested on the Azure Artifacts PyPI server I have access to and it works.

TODOs:

  • correct ported function name in commit message
  • make pipeline pass

@robin92 robin92 force-pushed the fix/port-PR-4086-to-1.1 branch 3 times, most recently from 071fd32 to e0edf85 Compare February 15, 2022 12:11
@robin92 robin92 force-pushed the fix/port-PR-4086-to-1.1 branch from efe30b3 to e4d46e1 Compare February 15, 2022 12:28
@robin92 robin92 marked this pull request as ready for review February 15, 2022 13:03
@Secrus
Copy link
Copy Markdown
Member

Secrus commented May 17, 2022

Poetry team has no plan for another 1.1.x release, so it won't be backported.

@Secrus Secrus closed this May 17, 2022
@Secrus Secrus added the wontfix label May 17, 2022
@github-actions
Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants