Skip to content

Backport PR #3337 - Fix handling errors 401, 403 when looking for repositories#5224

Closed
1ace wants to merge 1 commit into
python-poetry:1.1from
1ace:backport-pr-3337
Closed

Backport PR #3337 - Fix handling errors 401, 403 when looking for repositories#5224
1ace wants to merge 1 commit into
python-poetry:1.1from
1ace:backport-pr-3337

Conversation

@1ace
Copy link
Copy Markdown
Contributor

@1ace 1ace commented Feb 22, 2022

Backport of #3337 which fixes #3303 to the 1.1 branch, so that it can be part of the next 1.1.x release 🙂

/cc @finswimmer

Copy link
Copy Markdown

@Maciej-Zwolinski Maciej-Zwolinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jesus, why didn't anybody fix this before or has approved this merge earlier?

As is, the code handling 401 and 403 exceptions is inaccessible, hence should either be removed or moved before exception is raised to be actually functional. I lean heavily towards handling 40x exceptions instead of raising them and causing entire build process go to hell because somebody either forgot to log in or (more likely) you are trying to find non-existent packages in a private repository that returns 403 instead of 404 (looking at you pytorch...).

@Secrus
Copy link
Copy Markdown
Member

Secrus commented May 17, 2022

Poetry team won't do another 1.1.x release, so this PR is no longer valid. Closing.

@Secrus Secrus closed this May 17, 2022
@Maciej-Zwolinski
Copy link
Copy Markdown

Ok, thank you for clarification. I was not up to date with release schedule of poetry, since the 1.1.x is still the default version when looking for docs (https://python-poetry.org/docs/). Perhaps it'd be a good idea to point towards 1.2 as a recommended release (even if it's only in preview).

@github-actions
Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants