Skip to content

chore(repositories): remove type errors#5255

Merged
neersighted merged 1 commit into
python-poetry:masterfrom
branchv:mypy/repositories
May 15, 2022
Merged

chore(repositories): remove type errors#5255
neersighted merged 1 commit into
python-poetry:masterfrom
branchv:mypy/repositories

Conversation

@branchv
Copy link
Copy Markdown
Member

@branchv branchv commented Mar 1, 2022

Distribution seems to be mostly an abstract class, with a single concrete PathDistribution. We assume we're working with aPathDistribution, which has a _path but not publicly typed, so not sure what else to do besides type: ignore

@dimbleby
Copy link
Copy Markdown
Contributor

dimbleby commented Mar 2, 2022

I think that you are running the typechecking only through precommit? That runs in an environment that does not install most of the poetry dependencies, and as a result it misses most of the errors. So I believe that this MR - or if not specifically this MR then the recent sequence of typechecking MRs - is in a false paradise.

https://gist.github.com/dimbleby/b9133cbafee6e127418a538bd7986f75 is the set of errors that I currently get when running mypy from within the poetry environment.

@dimbleby
Copy link
Copy Markdown
Contributor

dimbleby commented Mar 5, 2022

#5279

@branchv
Copy link
Copy Markdown
Member Author

branchv commented Mar 26, 2022

I think that you are running the typechecking only through precommit?

good catch! you're definitely right, thanks for calling that out

@branchv branchv requested a review from a team April 27, 2022 21:32
@dimbleby
Copy link
Copy Markdown
Contributor

Looks good to me - I also don't see a better way.

@neersighted neersighted merged commit f33c9db into python-poetry:master May 15, 2022
@branchv branchv deleted the mypy/repositories branch May 16, 2022 16:15
@github-actions
Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants