chore(repositories): remove type errors#5255
Conversation
|
I think that you are running the typechecking only through precommit? That runs in an environment that does not install most of the poetry dependencies, and as a result it misses most of the errors. So I believe that this MR - or if not specifically this MR then the recent sequence of typechecking MRs - is in a false paradise. https://gist.github.com/dimbleby/b9133cbafee6e127418a538bd7986f75 is the set of errors that I currently get when running mypy from within the poetry environment. |
good catch! you're definitely right, thanks for calling that out |
|
Looks good to me - I also don't see a better way. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Distributionseems to be mostly an abstract class, with a single concretePathDistribution. We assume we're working with aPathDistribution, which has a_pathbut not publicly typed, so not sure what else to do besidestype: ignore