Skip to content

chore(installation): remove type errors#5260

Merged
neersighted merged 1 commit into
python-poetry:masterfrom
branchv:mypy/installation
May 18, 2022
Merged

chore(installation): remove type errors#5260
neersighted merged 1 commit into
python-poetry:masterfrom
branchv:mypy/installation

Conversation

@branchv
Copy link
Copy Markdown
Member

@branchv branchv commented Mar 2, 2022

No description provided.

Comment thread src/poetry/installation/executor.py Outdated
fd, name = tempfile.mkstemp("reqs.txt", f"{package.name}-{package.version}")
req = self.requirement(package, formatted=True)
if isinstance(req, list):
req = " ".join(req)
Copy link
Copy Markdown
Member Author

@branchv branchv Mar 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this codepath isn't currently reached, but handled it anyway

@dimbleby
Copy link
Copy Markdown
Contributor

dimbleby commented Mar 5, 2022

#5279

@branchv branchv requested a review from a team April 27, 2022 22:00
@neersighted neersighted merged commit 2ae46fa into python-poetry:master May 18, 2022
@branchv branchv deleted the mypy/installation branch May 18, 2022 13:14
@github-actions
Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants