solved mypy errors for poetry.console.application #5368
Conversation
branchv
left a comment
There was a problem hiding this comment.
thanks a lot for your contribution 👍 , I just have one comment
| io = event.io | ||
|
|
||
| loggers = [ | ||
| loggers: list[Any] = [ |
There was a problem hiding this comment.
Although this silences mypy, loggers is really only a list[str]. The actual issue stems from re-using the same variable name for different types. So a more direct solution would be to avoid it on line 235:
for logger_name in loggers:
logger = logging.getLogger(logger_name)|
@branchvincent thank you so much for your feedback, I understood your changes and reason behind that but I recently found out that someone is already working on this module for mypy errors there is an open PR for that Meanwhile I have taken up modules inside poetry.mixology will solve mypy errors for that and submit a New PR Please stay updated on this issue #5017 to review my Next PR |
|
sounds good @tarun-jethwani, I'll close this pr in favor of #5258 |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Pull Request Check List
Resolves: #5017