solved mypy errors for poetry.mixology#5402
Merged
abn merged 3 commits intoApr 27, 2022
Merged
Conversation
7 tasks
dimbleby
reviewed
Apr 3, 2022
tarun-jethwani
force-pushed
the
mypy-fix-errors-for-poetry-mixology
branch
from
45c72de to
6c2a5ed
Compare
…ge in src/poetry/puzzle/exceptions.py
Author
|
resolved merge conflicts |
abn
requested changes
Apr 15, 2022
Member
abn
left a comment
abn
left a comment
There was a problem hiding this comment.
Good work @tarun-jethwani few minor suggestions/questions.
Author
|
Hi @abn , thanks for your comments and review, I have resolved and taken care of your suggestions and questions, |
branchv
approved these changes
Apr 27, 2022
Member
branchv
left a comment
branchv
left a comment
There was a problem hiding this comment.
thanks @tarun-jethwani, this looks great to me. I'll wait a bit before merging to see if @abn has any other comments
Member
|
Thanks for handling this @branchvincent. @tarun-jethwani thank you for your patience, I think this looks good - will merge it shortly. |
abn
approved these changes
Apr 27, 2022
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
Relates-to: #5017
This PR fixes mypy errors for entire poetry.mixology package and remove those corresponding fixed modules from [[tool.mypy.overrides]] section in pyproject.toml file