more typechecking#5485
Conversation
db50123 to
8a0af05
Compare
|
(errors reported in #5476 would have been revealed by the typechecking, if poetry-core had a py.typed) |
db6cce7 to
8da1580
Compare
24263f0 to
69af602
Compare
|
This MR's project of cleaning up errors revealed by having a
which is #5476, more or less. cc @abn. (recent commits have mostly been finding a way around the typechecking when dealing with tomlkit, whose types seem to be... hard to use) |
|
Although I now see that because pre-commit runs in an incomplete environment - #5279 - it doesn't see all the errors that it should and therefore insists that I a making a redundant cast. Hmm. |
cc5bfd1 to
aa3a1b0
Compare
just use the appropriate base class, no need for the extra complexity
aa3a1b0 to
967a315
Compare
signal failure with `PackageNotFound`, rather than by returning None
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Experimenting with the effect of putting a
py.typedin poetry-core, so that types from poetry-core count for something over here.That generates lots and lots of new errors, I've picked off a fairly random selection of them here until I got bored.