Replace poetry.utils.appdirs with platformdirs#5527
Merged
Conversation
dimbleby
force-pushed
the
platformdirs
branch
4 times, most recently
from
62c86f4 to
09eaa32
Compare
Contributor
Author
|
pipelines reveal that platformdirs moves the config directory on MacOS from This seems to be a straight bug fix, but it is a change that will want highlighting in any changelog. See also discussion in platformdirs at tox-dev/platformdirs#47. I'll follow up now with the commit that switches to using platformdirs (and actually also another commit that prefers to use Then y'all can decide whether you actually want to take this fix, or prefer to keep the old code and behaviour. |
abn
reviewed
May 6, 2022
abn
reviewed
May 6, 2022
dimbleby
force-pushed
the
platformdirs
branch
2 times, most recently
from
c30a977 to
f8eac5c
Compare
abn
approved these changes
May 7, 2022
Merged
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As noted in #5524 (comment), platformdirs is already in the poetry dependency tree (via virtualenv), so it's not clear why we have our own copy of an old version of it.
This first commit uses the github pipelines to verify that platformdirs is indeed compatible, at least with all the places where we run pipelines. If that passes I'll follow up to make the changes that actually remove poetry.utils.appdirs