Skip to content

mypy: remove unused ignores#5577

Closed
abn wants to merge 2 commits into
python-poetry:masterfrom
abn:remove-mypy-ignores
Closed

mypy: remove unused ignores#5577
abn wants to merge 2 commits into
python-poetry:masterfrom
abn:remove-mypy-ignores

Conversation

@abn
Copy link
Copy Markdown
Member

@abn abn commented May 9, 2022

No description provided.

@abn abn requested a review from a team May 9, 2022 14:18
@abn abn marked this pull request as draft May 9, 2022 14:24
@abn
Copy link
Copy Markdown
Member Author

abn commented May 9, 2022

Seems to work locally 🤔 .

(.venv) $ poetry run mypy
Success: no issues found in 164 source files
(.venv) $ git log | head -n 1
commit b2df66756314ded097c01913de7ff1b2eba73aec
(.venv) $ poetry show mypy
 name         : mypy                              
 version      : 0.950                             
 description  : Optional static typing for Python 

dependencies
 - mypy-extensions >=0.4.3
 - tomli >=1.1.0
 - typed-ast >=1.4.0,<2
 - typing-extensions >=3.10
(.venv) $ poetry install
Installing dependencies from lock file

No dependencies to install or update

Installing the current project: poetry (1.2.0-beta.2.dev0)

@dimbleby
Copy link
Copy Markdown
Contributor

dimbleby commented May 9, 2022

I guess that locally you are running against a recent poetry-core, with a py.typed.

The pipeline is not; so it is not able to make use of the typing in that project.

@dimbleby
Copy link
Copy Markdown
Contributor

dimbleby commented May 9, 2022

cf 9ce2f74, from #5531

@dimbleby
Copy link
Copy Markdown
Contributor

dimbleby commented May 9, 2022

If this is particularly annoying, maybe disable the "unused-ignores-are-a-problem" flag until poetry-core is next published.

Then re-enable that flag and delete the unused ignores.

@abn
Copy link
Copy Markdown
Member Author

abn commented May 9, 2022

Ah. Thanks for clearing that up @dimbleby. It turns out I had installed a local path version of poetry-core earlier. This is okay for now. A new core release is coming soon.

@abn abn closed this May 9, 2022
@github-actions
Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants