mypy: remove unused ignores#5577
Closed
abn wants to merge 2 commits into
Closed
Conversation
Member
Author
|
Seems to work locally 🤔 . (.venv) $ poetry run mypy
Success: no issues found in 164 source files
(.venv) $ git log | head -n 1
commit b2df66756314ded097c01913de7ff1b2eba73aec
(.venv) $ poetry show mypy
name : mypy
version : 0.950
description : Optional static typing for Python
dependencies
- mypy-extensions >=0.4.3
- tomli >=1.1.0
- typed-ast >=1.4.0,<2
- typing-extensions >=3.10
(.venv) $ poetry install
Installing dependencies from lock file
No dependencies to install or update
Installing the current project: poetry (1.2.0-beta.2.dev0)
|
Contributor
|
I guess that locally you are running against a recent poetry-core, with a The pipeline is not; so it is not able to make use of the typing in that project. |
Contributor
Contributor
|
If this is particularly annoying, maybe disable the "unused-ignores-are-a-problem" flag until poetry-core is next published. Then re-enable that flag and delete the unused ignores. |
Member
Author
|
Ah. Thanks for clearing that up @dimbleby. It turns out I had installed a local path version of |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.