tests: make tests compatible with core > 1.1.0a7#5589
Merged
Conversation
radoering
force-pushed
the
fix-normalize-version-tests
branch
from
ea11862 to
7b79f15
Compare
abn
reviewed
May 10, 2022
| def test_increment_version( | ||
| version: str, rule: str, expected: str, command: VersionCommand | ||
| ): | ||
| if not parse_constraint(">1.1.0a7").allows( |
Member
There was a problem hiding this comment.
We should probably move all these into a compat variable in test utils. So we can remove them easily.
radoering
force-pushed
the
fix-normalize-version-tests
branch
from
7b79f15 to
8743a71
Compare
abn
approved these changes
May 10, 2022
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Downstream tests in poetry-core did not fail in python-poetry/poetry-core#344 and in master after merging, but are failing in new PRs!?