source show: include pypi and additional information about order#5680
source show: include pypi and additional information about order#5680abn wants to merge 2 commits into
Conversation
abn
commented
May 24, 2022
|
Deploy preview for website ready! ✅ Preview Built with commit 5869194. |
| ["<info>url</>", f" : {source.url}"], | ||
| [ | ||
| "<info>default</>", | ||
| f" : {bool_string.get(source.default, False)}", |
There was a problem hiding this comment.
Shouldn't this False be "no"? And the same in line 38?
There was a problem hiding this comment.
False is the default value if source.default is None.
There was a problem hiding this comment.
ok, but if I understand this right, we want to display default: yes or default: no. With False, it will be default: False.
There was a problem hiding this comment.
Ah, fair point... bool_string.get(bool(source.default)) might lead to the desired behavior.
|
Closing in favour of #9974. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |