Skip to content

pypi: do not raise exception on 404 #5698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
neersighted merged 2 commits into from
May 27, 2022
+7 −3
Merged

pypi: do not raise exception on 404 #5698

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
090cb4f
pypi: do not raise exception on 404
abn May 26, 2022
9e5cbf3
Update src/poetry/repositories/pypi_repository.py
abn May 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/poetry/repositories/pypi_repository.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,14 +243,18 @@ def _get_release_info(

def _get(self, endpoint: str) -> dict[str, Any] | None:
try:
json_response = self.session.get(self._base_url + endpoint)
json_response = self.session.get(
self._base_url + endpoint, raise_for_status=False
Comment thread
abn marked this conversation as resolved.
)
except requests.exceptions.TooManyRedirects:
# Cache control redirect loop.
# We try to remove the cache and try again
self.session.delete_cache(self._base_url + endpoint)
json_response = self.session.get(self._base_url + endpoint)
json_response = self.session.get(
self._base_url + endpoint, raise_for_status=False
)

if json_response.status_code == 404:
if json_response.status_code != 200:
return None

json: dict[str, Any] = json_response.json()
Expand Down