repositories/http: support algorithms in hashlib.algorithms_guaranteed#6632
Closed
vfazio wants to merge 1 commit intopython-poetry:masterfrom
Closed
repositories/http: support algorithms in hashlib.algorithms_guaranteed#6632vfazio wants to merge 1 commit intopython-poetry:masterfrom
vfazio wants to merge 1 commit intopython-poetry:masterfrom
Conversation
Signed-off-by: Vincent Fazio <vfazio@xes-inc.com>
Member
|
This does not resolve #6301 -- hash handling code is much more involved than this and there are no tests that actually make sure the intended fix really happens. I would suggest instead syncing with the authors of other attempts (e.g. #6490, #4740, #5326) to maybe combine efforts or see what is needed. I have my own refactor spinning locally as well -- it's much more holistic and security-focused than a straight forward-port, but may take more time to cook. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PEP 503 says:
It should make sense, then, to just check that the value returned is in
hashlib.algorithms_guaranteedinstead of a short subset of hashes.Otherwise, the subset of hashes should be extended to those directly mentioned in the PEP though that list was compiled 7 years ago and does not reflect algorithms guaranteed to be present.
Pull Request Check List
Resolves: