Skip to content

Handle distribution.files being None#6855

Closed
jace-ys wants to merge 1 commit intopython-poetry:masterfrom
jace-ys:master
Closed

Handle distribution.files being None#6855
jace-ys wants to merge 1 commit intopython-poetry:masterfrom
jace-ys:master

Conversation

@jace-ys
Copy link
Copy Markdown
Contributor

@jace-ys jace-ys commented Oct 21, 2022

Pull Request Check List

Resolves: #6788

We discovered that in some unknown situations, distribution.files can be None, causing the assertion to fail. To handle distribution.files being None more gracefully, we treat it as if it were an empty list.

  • Added tests for changed code.
  • Updated documentation for changed code.

@jace-ys jace-ys force-pushed the master branch 2 times, most recently from e5c5bdc to 4161e43 Compare October 21, 2022 01:02
@jace-ys jace-ys marked this pull request as ready for review October 21, 2022 08:57
@jace-ys jace-ys mentioned this pull request Oct 21, 2022
4 tasks
@jace-ys
Copy link
Copy Markdown
Contributor Author

jace-ys commented Oct 24, 2022

Closing in favour of #6877 (just a change in branch of my fork)

@jace-ys jace-ys closed this Oct 24, 2022
@github-actions
Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AssertionError from Poetry install

1 participant