Skip to content

docs(poetry-add-help): resolve discrepancy between cli help and webpa…#6889

Closed
tjzegmott wants to merge 2 commits intopython-poetry:masterfrom
tjzegmott:fix-poetry-add-docs-discrepancy
Closed

docs(poetry-add-help): resolve discrepancy between cli help and webpa…#6889
tjzegmott wants to merge 2 commits intopython-poetry:masterfrom
tjzegmott:fix-poetry-add-docs-discrepancy

Conversation

@tjzegmott
Copy link
Copy Markdown

@tjzegmott tjzegmott commented Oct 25, 2022

Pull Request Check List

Resolves: #6887

  • Added tests for changed code.
  • Updated documentation for changed code.

Small changes to poetry add's docstring to fix discrepancy with the webpage.

@neersighted
Copy link
Copy Markdown
Member

I actually think we should drop the SSH lines entirely -- a "Git URL" encompasses multiple protocols, such as HTTPS, HTTP (see #6619), Git (the wire-protocol), and SSH. We could add a list of accepted protocols as Poetry does not (currently) accept HTTP, and we do not intend to support git+file:// or git+git:// if you think being explicit is better; however, the latter are so rarely used that I think the error message might be sufficient.

Copy link
Copy Markdown
Member

@neersighted neersighted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per my PR comment.

@tjzegmott tjzegmott closed this Dec 8, 2023
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 3, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Poetry add help discrepancy

3 participants