wip: use pypa/installer to install wheels#7031
Closed
abn wants to merge 1 commit intopython-poetry:masterfrom
Closed
wip: use pypa/installer to install wheels#7031abn wants to merge 1 commit intopython-poetry:masterfrom
abn wants to merge 1 commit intopython-poetry:masterfrom
Conversation
Member
Author
|
@neersighted think we briefly talked about this one a while ago. |
cd489a1 to
a942e62
Compare
a942e62 to
01b6b9e
Compare
Member
Author
|
Missed the changes added in #6205. @sdispater you still actively working on that one? |
Member
Author
|
I am going to drop this one in favour of #6205 as that is more comprehensive. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An initial step towards dropping
pipto install packages. Once there is a more performant iteration of #5650 we should be able to replacePipInstallerwith aNativeInstallerthat uses a combination ofbuild(to build wheels from source),EditableBuilderto install editable sources andinstallerto install wheels. The editable installs should already be doable.In the interim, this is an experimentation for early feedback on using
installerto install already available wheels. The initial results are quite promising. On my development environment, once the cache is populated, the following times were recorded for 10 iterations for the following command andpyproject.toml.pyproject.toml
Without patch
With patch
If enabling this we should allow for
experimentalas there could be edge cases around how platform wheels will be installed.